Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix use of undefined and displayValue in Combobox #1865

Merged
merged 2 commits into from
Sep 19, 2022

Conversation

thecrypticace
Copy link
Contributor

When the combobox box is given a v-model ref that is undefined we do not call displayValue and can end up displaying the string undefined. This is actually a bug in Vue itself (vuejs/core#5032) but we can work around this by passing a dummy ref that has a defined value. This allows immediate to work as expected.

Fixes #1861

@vercel
Copy link

vercel bot commented Sep 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
headlessui-react ✅ Ready (Inspect) Visit Preview Sep 19, 2022 at 1:51PM (UTC)
headlessui-vue ✅ Ready (Inspect) Visit Preview Sep 19, 2022 at 1:51PM (UTC)

@thecrypticace
Copy link
Contributor Author

That flaky transition test is driving me up the wall lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combobox' label shows "undefined": Should be empty
1 participant